Skip to content

Patch NiFi assembly to not zip binaries to save disk space#685

Merged
maltesander merged 2 commits intomainfrom
fix/reduce-build-size
May 17, 2024
Merged

Patch NiFi assembly to not zip binaries to save disk space#685
maltesander merged 2 commits intomainfrom
fix/reduce-build-size

Conversation

@maltesander
Copy link
Copy Markdown
Member

@maltesander maltesander commented May 17, 2024

Description

For NiFi version 1.21.0 and 1.23.2 the github runners do not have enough space and fail to build these images:

Error: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.0:install (default-install) on project nifi-toolkit-assembly: Failed to install artifact org.apache.nifi:nifi-toolkit-assembly:zip:bin:1.21.0: No space left on device -> [Help 1]

The nifi-assembly zips the resulting binaries which adds another ~1.3 GB but are not used in the main image since the unzipped binaries are copied over.

This PR patches the pom file to not zip the binaries in the end to save disk space.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@maltesander maltesander requested a review from soenkeliebau May 17, 2024 13:16
@maltesander maltesander self-assigned this May 17, 2024
@maltesander maltesander mentioned this pull request May 17, 2024
Closed
@maltesander maltesander marked this pull request as ready for review May 17, 2024 13:25
Jimvin
Jimvin approved these changes May 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Jimvin Jimvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit bbfc576 May 17, 2024
@maltesander maltesander deleted the fix/reduce-build-size branch May 17, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jimvin Jimvin Jimvin approved these changes

@soenkeliebau soenkeliebau Awaiting requested review from soenkeliebau

Assignees

@maltesander maltesander

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maltesander @Jimvin